spaceninja + pullrequest   12

Good Code Reviews, Better Code Reviews
I have been doing day to day code reviews for over a decade now. The benefits of code reviews are plenty: from someone else reading through the change, through knowledge sharing all the way to tooling and automation improvements. If you are not doing code reviews, take the advice from Jeff Atwood shared in 2006 and just do it.
codereviews  pullrequest  culture 
june 2019 by spaceninja
Make it hard to screw up driven development
We'll always be screwing up code, but we can also always be finding ways not to… There is probably no practical way to make it impossible to write sloppy, bad code, but it is fascinating to consider how tooling has evolved to make it harder. Let's get all Poka-yoke on development.
fridayfrontend  devtools  linting  testing  validation  codereviews  pullrequest  quality 
april 2019 by spaceninja
How To Review Code You Don't Understand
1. Reduce risk; 2. Focus on the tests; 3. State assumptions; 4. Review at the level you do understand;
codereviews  pullrequest  programming  engineering  culture  management  leadership 
december 2018 by spaceninja
8 Tips for Great Code Reviews
Code reviews are a critical process to creating great software. Code that’s reviewed tends to be of higher quality and have fewer bugs. A healthy code review culture provides ancillary benefits as well: you limit the bus factor, it’s a great tool for training new members, and code reviews are great ways of sharing knowledge.
codereviews  pullrequest  git  github  feedback  culture 
october 2018 by spaceninja
Github Templates in Ten Minutes
The better your team communicates, the more time you can spend on the fun stuff -- building interesting things and solving hard problems. When you're looking for ways to improve communication, take a look at Github. They’ve rolled out two features that should be incorporated into any project: Pull Request templates and Issue templates. In this post, I’ll walk through these tools and how to leverage them on your next (or current) project.
git  github  templates  pullrequest 
september 2018 by spaceninja
Faster PR Pulls with Git Aliases
I love the traditional GitHub workflow of receive pull request, pull down pull request to test, and merge the pull request.  GitHub makes the first and the third steps easy but pulling down pull requests from new contributors requires some boilerplate work that annoys me...
git  github  alias  pullrequest  forks 
march 2018 by spaceninja
Create GitHub Pull Request and Issue Templates
I recently found out you an create pull request and issues templates so that when the user goes to file a pull request or issue, your template displays within the description textarea.  Let's have a look at how we can do that!
github  git  pullrequest  templates  bugs  reports 
february 2018 by spaceninja
How to Get Faster PR Reviews
Great collection of common-sense wisdom to pass along to junior devs as a reminder to keep code reviews well-documented and small enough to review.
git  github  pullrequest  codereviews  reviews 
december 2016 by spaceninja
Ideas Around Code Reviewing
"One of the things that we’ve been looking into improving at Wave HQ recently is our process of code reviewing, from the time someone is preparing to open a pull request to the time approved changes are deployed to production. There’s a lot of things that can occur during this time that can waste time and add technical debt."
git  code  reviews  pullrequest 
november 2016 by spaceninja
How to squash commits in a GitHub pull request
"So you've contributed some code to an open source project, say, Rails. And they'd like you to squash all of the commits in your pull request. But you're not a git wizard; how do you make this happen?"
git  rebase  squash  github  pullrequest  fridayfrontend 
february 2016 by spaceninja
Clean up your commits for a pull request
When you contribute to an Open Source project through a pull request, the maintainer often wants you to clean up your commits. I will show you what that means and why git rebase is your command of choice here.
git  github  rebase  pullrequest  merge  clean  history 
july 2015 by spaceninja
“Merge pull request” Considered Harmful
Turns out git was built to make this situation easy to deal with, and the only thing that was really holding me back was the workflow that Github puts front and center. So I stopped using the “Merge pull request” button, and instead I now do this:
git  github  workflow  merge  pullrequest  pull 
august 2014 by spaceninja

Copy this bookmark: